abo-abo / ace-window

Quickly switch windows in Emacs
970 stars 86 forks source link

Invocations of ace-window scroll current window #166

Closed mrkkrp closed 5 years ago

mrkkrp commented 5 years ago

This is the bug introduced by solution to #165.

Instructions how to reproduce it:

  1. Run Emacs like this emacs -Q to avoid loading personalized configuration.
  2. Evaluate (package-initialize).
  3. Evaluate (require 'ace-window).
  4. Open a file which is long enough not to fit in a window all at once.
  5. Split window vertically, then horizontally. This is just so we can have the actual markers when we run ace-window.
  6. Evaluate (setq scroll-margin 3) setting scroll margin.
  7. Now run ace-window.
  8. Observe how the current window is scrolled. You can hit Ctrl-g now cancelling actual jump.
  9. Repeat 7-8 till it's obvious enough that something is really wrong.

cc @rswgnu

mrkkrp commented 5 years ago

That fix was really unfortunate, I'd be OK with just reverting that. The bug is very very very annoying.

mrkkrp commented 5 years ago

I suffer every day.

mrkkrp commented 5 years ago

@rswgnu @abo-abo So you asked for a way to reproduce the problem and I provided that, can we move forward with this?

rswgnu commented 5 years ago

Did you try my patch and did it resolve your issues?

mrkkrp commented 5 years ago

I wasn't aware of your patch because GitHub did not notify me about it. I'm going to try it shortly.