search

abo-abo / ace-window

Quickly switch windows in Emacs
970 stars 86 forks source link

Ace window doesn't display window number in overlay when the first line in the window is a blank line #175

Closed quanticle closed 5 years ago

quanticle commented 5 years ago

If the buffer scrolls past the end of the window, and the first line in the window is a blank line, the window number doesn't show if ace-window overlay is enabled.

To reproduce:

  1. Create a file (e.g. test.txt)
  2. Add a bunch of blank lines (e.g. C-u 500 RET)
  3. C-x 3 to split the window vertically
  4. C-x 2 to create a horizontal split
  5. Scroll down a page or two with C-v
  6. M-o (or whatever your ace-window key is)
  7. Note that the window numbers don't show any more in the overlay
quanticle commented 5 years ago

After further investigation, it doesn't look like the overlay has anything to do with the problem, since it occurs even when I have (setq aw-background nil).

pkryger commented 5 years ago

@quanticle I submitted #176 for slightly different scenario leading to missing overlay number. Perhaps this one is caused in similar circumstances?

abo-abo commented 5 years ago

Thanks, please test.

quanticle commented 5 years ago

Sorry it took me so long to respond! I didn't see that the issue was closed. I retested with an updated ace-window and can verify that the problem is fixed.

Thanks for taking care of this!

abo-abo commented 5 years ago

Thanks for the follow up.