Closed notmgsk closed 1 year ago
Thanks. Looks good. Do you have an Emacs Copyright Assignment? Both ace-window
and posframe
are on https://elpa.gnu.org/packages/.
Working on it. Will let you know once it's done.
Thanks in advance.
I'm using this with (set-face-attribute 'aw-leading-char-face nil :weight 'bold :height 2.0)
and the height scale in particular makes the labels stand out. I think it's probably too opinionated to set as a default, but perhaps it warrants inclusion in an example adjacent to the documentation for ace-window-posframe-mode
in the eventual readme.
This is a useful patch for a great package! Thanks to you both.
@abo-abo Finally I have the copyright assignment. I'm going to take a look at this again, and address the comments above.
@notmgsk: The posframe display delay probably occurs because posframe creation takes a bit of time. You can mitigate the problem by caching and hiding posframes (and lazily creating them as needed, and/or pre-creating a bunch when Emacs idles).
@notmgsk: The posframe display delay probably occurs because posframe creation takes a bit of time. You can mitigate the problem by caching and hiding posframes (and lazily creating them as needed, and/or pre-creating a bunch when Emacs idles).
Thanks. The lazy approach is already implemented, and has been sufficient for my usage.
Hello! Thank you for ace-window! Is there a reason to not merge this PR?
Merged. Thanks @notmgsk for the contribution. And to everyone who reviewed. And @josephmturner for the ping.
@abo-abo @notmgsk Thank you!! This will make ace-window work much better with EXWM.
Use posframes for overlays.
There does seem to be a slight but noticable delay when displaying the posframes. Haven't investigated too much into why.