abo-abo / ace-window

Quickly switch windows in Emacs
970 stars 86 forks source link

Provide ace-window-posframe-mode #192

Closed notmgsk closed 1 year ago

notmgsk commented 4 years ago

Use posframes for overlays.

There does seem to be a slight but noticable delay when displaying the posframes. Haven't investigated too much into why.

abo-abo commented 4 years ago

Thanks. Looks good. Do you have an Emacs Copyright Assignment? Both ace-window and posframe are on https://elpa.gnu.org/packages/.

notmgsk commented 4 years ago

Working on it. Will let you know once it's done.

abo-abo commented 4 years ago

Thanks in advance.

obar commented 4 years ago

I'm using this with (set-face-attribute 'aw-leading-char-face nil :weight 'bold :height 2.0) and the height scale in particular makes the labels stand out. I think it's probably too opinionated to set as a default, but perhaps it warrants inclusion in an example adjacent to the documentation for ace-window-posframe-mode in the eventual readme.

This is a useful patch for a great package! Thanks to you both.

notmgsk commented 3 years ago

@abo-abo Finally I have the copyright assignment. I'm going to take a look at this again, and address the comments above.

gcv commented 3 years ago

@notmgsk: The posframe display delay probably occurs because posframe creation takes a bit of time. You can mitigate the problem by caching and hiding posframes (and lazily creating them as needed, and/or pre-creating a bunch when Emacs idles).

notmgsk commented 3 years ago

@notmgsk: The posframe display delay probably occurs because posframe creation takes a bit of time. You can mitigate the problem by caching and hiding posframes (and lazily creating them as needed, and/or pre-creating a bunch when Emacs idles).

Thanks. The lazy approach is already implemented, and has been sufficient for my usage.

josephmturner commented 1 year ago

Hello! Thank you for ace-window! Is there a reason to not merge this PR?

abo-abo commented 1 year ago

Merged. Thanks @notmgsk for the contribution. And to everyone who reviewed. And @josephmturner for the ping.

josephmturner commented 1 year ago

@abo-abo @notmgsk Thank you!! This will make ace-window work much better with EXWM.