abo-abo / ace-window

Quickly switch windows in Emacs
965 stars 85 forks source link

aw-empty-buffers-list contains killed buffer #213

Open richkinder opened 2 years ago

richkinder commented 2 years ago

Every once in awhile ace-window breaks until I restart Emacs. This occurs when a buffer in aw-empty-buffers-list gets killed, because then at

https://github.com/abo-abo/ace-window/blob/c7cb315c14e36fded5ac4096e158497ae974bec9/ace-window.el#L294

the with-current-buffer call fails. This results in aw-empty-buffers-list never getting set to nil.

Maybe a (when (buffer-live-p b) right before the with-current-buffer call would resolve this? It's just a one-liner but I'm happy to make a PR if this sounds like a desired change.