abo-abo / auto-yasnippet

quickly create disposable yasnippets
246 stars 15 forks source link

Change cl-some #'listp to listp in aya-create #34

Closed ymarco closed 2 years ago

ymarco commented 4 years ago

res seems to be a list of strings, not a list of lists. aya-create was not working for me before this change, it didn't register the region, and now it does.

ymarco commented 3 years ago

Any updates on this?

ymarco commented 3 years ago

ping

jasonm23 commented 2 years ago

Looks like this project is stalled. Paging @abo-abo

abo-abo commented 2 years ago

@ymarco What was your use case? It seems to me the current code is working as intended:

(aya--parse "foo bar")
;; => ("foo bar")

(aya--parse "~foo bar")
;; => (((idx . 1) (value . "foo") (ucase)) " bar")
ymarco commented 2 years ago

I honestly don't remember anything past what I've written when opening the PR

abo-abo commented 2 years ago

@ymarco No problem. I'll close the issue. But reading this gave me an idea of improving my config:

(aya--parse "foo bar") ;; => ("foo bar")

if no vars are detected, it's just a list with a string in it. Very similar to a copied region.

So why not have auto-yasnippet handle copying regions?

To keybindings can be saved this way.