avy.el: Add org-mode commands for jumping to and refiling headings

abo-abo / avy

Jump to things in Emacs tree-style

1.72k stars 110 forks source link

avy.el: Add org-mode commands for jumping to and refiling headings #214

Closed alphapapa closed 7 years ago

alphapapa commented 7 years ago

Hi Oleh,

Here is the PR we talked about. My FSF CA for Emacs and Org is complete.

Thanks, Adam

(avy-org-refile-as-child): Refile current heading to a heading selected with Avy.
(avy-org-goto-heading-timer): Jump to a heading selected with Avy. Like avy-goto-char-timer, but for Org headings.
(avy--read-string-with-timeout): Read a string from the minibuffer with a timeout. Basically factored out of avy-goto-char-timer.

abo-abo commented 7 years ago

Thanks for the contribution. Please review my change to avy-org-goto-heading-timer. Thanks to the new var in avy--read-candidates, avy-org-goto-heading-timer is now almost the same as avy-goto-char-timer.

alphapapa commented 7 years ago

Thanks, that is a good way to handle it.

tarsius commented 7 years ago

This results in new compile warnings:

In toplevel form:
avy.el:543:1:Warning: Unused lexical variable ‘org-reverse-note-order’

In avy-org-refile-as-child:
avy.el:549:40:Warning: reference to free variable ‘avy-goto-line’

In avy-org-goto-heading-timer:
avy.el:566:15:Warning: reference to free variable ‘avy-goto-char-timer’

In avy-with:
avy.el:617:11:Warning: macro ‘avy-with’ defined too late

In end of data:
avy.el:1911:1:Warning: the following functions are not known to be defined:
    org-refile, org-back-to-heading

abo-abo commented 7 years ago

@tarsius Fixed, thanks.