search

abo-abo / avy

Jump to things in Emacs tree-style
1.72k stars 110 forks source link

Add window selection via mouse button press and fix typo #226

Closed rswgnu closed 6 years ago

rswgnu commented 6 years ago

When avy is used for window selection, this allows a mouse press to substitute for selection via lead characters. It is used by ace-window.

abo-abo commented 6 years ago

Thanks, I added avy-mouse-press-event-p, renamed to avy-mouse-event-window.

See also the follow up commit: the mouse event is now routed to aw-dispatch-default and can be processed there.

rswgnu commented 6 years ago

Can you point me to this follow up commit? I don't see it. So I don't see anywhere that avy-mouse-event-window is called.

Also, in this commit I had fixed a problem with avy-current-path not containing the full path to the current point, so it was not usable by other functions to check the current avy path. But this was not part of your commit. (We had discussed this previously).

abo-abo commented 6 years ago

Can you point me to this follow up commit? I don't see it. So I don't see anywhere that avy-mouse-event-window is called.

It's https://github.com/abo-abo/avy/commit/176f34f4913d44efa29d84fd977a76ffb20a9b43. I referenced it in the https://github.com/abo-abo/avy/pull/226 thread.

Also, in this commit I had fixed a problem with avy-current-path not containing the full path to the current point, so it was not usable by other functions to check the current avy path. But this was not part of your commit. (We had discussed this previously).

OK, I'll add this change.