search

abo-abo / avy

Jump to things in Emacs tree-style
1.72k stars 110 forks source link

Searching for in/visible points doesn't use invisibility property correctly #237

Closed rnkn closed 5 years ago

rnkn commented 6 years ago

It appears that avy--next-visible-point and/or avy—next-invisible-point consider any text with the invisible text property to be invisible, and so exclude it from searching. However text is only invisible if the cdr of the invisible text property is included in the variable buffer-invisibility-spec.

Please see: https://www.gnu.org/software/emacs/manual/html_node/elisp/Invisible-Text.html

Reference: https://github.com/rnkn/fountain-mode/issues/85#issuecomment-383362701

rnkn commented 5 years ago

Bumping this as it means avy doesn't function in a lot more use cases than one might imagine.

abo-abo commented 5 years ago

Please provide a reproduction scenario. Some code regarding buffer-invisibility-spec was added to avy--visible-p in January this year.

rnkn commented 5 years ago

I don't use avy, it was causing issues for users of another package. If avy has since implemented with buffer-invisibility-spec as per the manual (linked above) then I'd say it's all good!

abo-abo commented 5 years ago

OK, I'll close the issue then. Thanks.