search

abo-abo / avy

Jump to things in Emacs tree-style
1.72k stars 110 forks source link

Add arg to avy--process to prevent window/frame selection #260

Closed noctuid closed 5 years ago

noctuid commented 5 years ago

This argument is necessary for avy--process to be usable by ivy-posframe. When using ivy-posframe, the call to select-frame-set-input-focus deselects the minibuffer, causes the ivy cleanup function to run prematurely, and causes Emacs to hang.

Addresses tumashu/ivy-posframe#6.

Based on the on the linked page, this should not be a legally significant change.

tumashu commented 5 years ago

@abo-abo

abo-abo commented 5 years ago

Thanks, but I wanted to make this a bit more extensible; also I want avy--process to have only one arg in the future.

You can now let-bind avy-pre-action to do what you want. Please test.

noctuid commented 5 years ago

Thanks! It might be a little nicer if there was a (when avy-pre-action... check, so that it could be set to nil instead of (lambda ()) or 'ignore.

abo-abo commented 5 years ago

I think 'ignore is a better way to go. This way, avy-pre-action has a more consistent "type".