abo-abo / avy

Jump to things in Emacs tree-style
1.71k stars 109 forks source link

Invalid face reference: aw-key-face #318

Open duianto opened 3 years ago

duianto commented 3 years ago

Invalid face reference: aw-key-face [144 times]

That message is shown in the messages buffer after these steps: With avy installed (no configurations).

Observed

The keys are listed in the minibuffer as expected:

x: kill-move X: kill-stay t: teleport m: mark n: copy y: yank Y: yank-line i: ispell z: zap-to-char

But the C-h e messages buffer, shows the message:

Invalid face reference: aw-key-face [144 times]

Cause

The face is used here: https://github.com/abo-abo/avy/blob/e92cb37457b43336b765630dbfbea8ba4be601fa/avy.el#L485

It seems to have been introduced here: avy.el (avy-show-dispatch-help): Add and bind to "?" https://github.com/abo-abo/avy/commit/9a15d1f37b99a18d8f05e0c4f7362b67e6766130

but the aw-key-face might never have been defined.

System

avy-20201226.1734 GNU Emacs 27.1 (build 1, x86_64-w64-mingw32) of 2020-08-21 Windows 10 2004

llliilii commented 1 year ago

It turns out to be defined in ace-window.el.

https://github.com/abo-abo/ace-window/blob/77115afc1b0b9f633084cf7479c767988106c196/ace-window.el#L215

@abo-abo Any update for this issue?