search

abo-abo / lispy

Short and sweet LISP editing
http://oremacs.com/lispy/
1.21k stars 132 forks source link

[lispy-clojure.el] why is pomegranate being used to pull in dependencies out of band? #441

Open vxe opened 6 years ago

vxe commented 6 years ago

here: https://github.com/abo-abo/lispy/blob/master/lispy-clojure.clj#L30 https://github.com/abo-abo/lispy/blob/master/lispy-clojure.clj#L39 https://github.com/abo-abo/lispy/blob/master/lispy-clojure.clj#L40

docs:

Please note that there are a number of scenarios in which add-dependencies will not work, or will not work as you'd expect. Many of these are due to the nature of JVM classloaders (e.g. adding jars containing conflicting versions of a particular dependency will rarely end well), which Pomegranate does not currently attempt to hide. Thus, add-classpath and add-dependencies should be considered escape hatches to be used when necessary, rather than a regular part of your development workflow.

Why can't this be rolled into a package in clojars with deps specified explicitly?

vxe commented 6 years ago

regardless the only dep that was giving me trouble was cider-nrepl:

https://github.com/abo-abo/lispy/pull/442/files

lispy-clojure> 

Testing lispy-clojure-test

Ran 11 tests containing 43 assertions.
0 failures, 0 errors.
abo-abo commented 6 years ago

Why can't this be rolled into a package in clojars with deps specified explicitly?

One reason is that I don't know enough about clojars to do it. The second reason is that the current approach is convenient for experimenting.