search

abo-abo / lispy

Short and sweet LISP editing
http://oremacs.com/lispy/
1.21k stars 132 forks source link

evaluating in lispy do not set cider breakpoint #529

Closed Andre0991 closed 4 years ago

Andre0991 commented 4 years ago

Hi.

In cider, one can add wrap a form with #break and evaluate it in order to create a breakpoint. The next time the form is run, cider steps in and displays its debugger interface (see 1).

The issue is that when using e in lispy in order to evaluate something, cider does not create the breakpoint. So the next time the form is run, it won't stop.

abo-abo commented 4 years ago

I've examined the issue, with the latest CIDER:

  1. You can still instrument functions with xe; evaluating an expression with e triggers that breakpoint
  2. When e is used on a function with #break, evaluating an expression with e does not trigger the breakpoint
  3. When cider-eval-last-sexp is used on a function with #break, evaluating an expression with e does trigger the breakpoint

So it remains to fix point 2, with 3 and 1 being workarounds.

abo-abo commented 4 years ago

Thanks, please test.

Andre0991 commented 4 years ago

I can confirm it works, thanks.