search

abo-abo / lispy

Short and sweet LISP editing
http://oremacs.com/lispy/
1.2k stars 130 forks source link

Cannot type " " in eval-expression's prompt when using edebug #613

Open daanturo opened 2 years ago

daanturo commented 2 years ago

Steps to reproduce:

  1. (add-hook 'eval-expression-minibuffer-setup-hook 'lispy-mode) to enable lispy-mode in M-:
  2. Activate edebug somewhere
  3. Press e (edebug-eval-expression)
  4. Type " "

Expected

" " is typed

Result

Message: Edebug will stop at next stop point.. Nothing is typed in the prompt.

GavinFrazar commented 1 year ago

Related: when edebug is active, any buffer with lispy active will forward to edebug, i.e. if the point is at |(some-func) in a common lisp buffer and I type f, then special-lispy-flow is called and rather than calling lispy-flow in my common lisp buffer, it calls edebug-forward-sexp in whatever buffer edebug is running in.

I think lispy--edebug-commandp should check that edebug-mode (which is buffer-local) evals to t, since edebug-active is not buffer local. That change fixed the problem for me.