search

abo-abo / lispy

Short and sweet LISP editing
http://oremacs.com/lispy/
1.2k stars 130 forks source link

lispy-occur is in its own file #616

Closed aaronjensen closed 2 years ago

aaronjensen commented 2 years ago

Ensures that swiper and ivy only load on demand.

@abo-abo I'm not sure if you'd like this, but it helps work around some of the issue of #610. It will still require and load swiper/ivy as needed. The only exception is one call to ivy--get-window. Because that is not an autoload function, it will fail if ivy isn't loaded explicitly. A require could be added there, but I'm not sure that's the best approach.

abo-abo commented 2 years ago

Thanks, merged. See also the follow-up commit.

aaronjensen commented 2 years ago

That’s great, thanks. Is the manual auto load necessary for cases where people do not generate an auto load file? That’s an area of emacs that is a mystery to me because straight.el just does it all for me.

aaronjensen commented 2 years ago

Also should there be an auto load declaration for ivy-read?

abo-abo commented 2 years ago

ivy-read is already autoloaded. The manual autoload is necessary because below we have:

(lispy-define-key map "y" 'lispy-occur)