search

abo-abo / lispy

Short and sweet LISP editing
http://oremacs.com/lispy/
1.19k stars 129 forks source link

Small improvements to `lispy-eval` #682

Open lane-s opened 1 week ago

lane-s commented 1 week ago

First of all, thanks for the great package!

I've been using lispy for a long time, but when I recently switch over to doom emacs, I noticed lispy-eval wasn't working as I expected in the overlay mode. It was defaulting to using cider when it should've been using eros (for Common Lisp and emacs lisp). Also, the formatting included extra quotes. This PR fixes these issues.

I haven't checked the changes with clojure yet, but I suspect there's something broken there as well (cider is now insisting on a symbol argument for cider--display-interactive-eval-result).

lane-s commented 1 week ago

Ah, someone's already made a PR for the cider part. I expect it will conflict with mine, but I'm happy to resolve the conflicts if #672 gets merged first.