counsel-rg doesn't display partial results if rg exits with error code

[Ruin0x11]

If rg called by counsel-rg returns an error code, it will discard any incremental results it found and display Error code 2 instead, even if it found matches for files it did have access to.

This usually happens if some of the files in the rg directory cannot be accessed by rg because of permissions issues on some subset of the files. However I can still use rg on the console and get a list of valid results anyways (interspersed with error messages). You can even see these incremental results in counsel-rg so long as it's still searching, but it discards them all when it finishes because of the error. Now a single unreadable file in the entire project can render counsel-rg inoperable.

[abo-abo]

I tested with the following:

• GNU Linux, Emacs-26.3
• ripgrep 0.10.0 (rev 8a7db1a918)
• git repo with 2 files, owned by my user
• chmod -r on the first file, opening it from Emacs shows find-file-noselect-1: File is not readable:...

counsel-rg returns results for the second file, while for the first file, a single Permission denied (os error 13) is shown.

This behavior seems correct to me.

[Ruin0x11]

This is my setup:

• Emacs 26.2
• Windows 10 1903 (18362.476)
• ivy 20190919.1331
• ripgrep 11.0.2 (rev 3de31f7527)
• Ran counsel-rg in a folder with one large accessible file and one directory will all access permissions revoked.

[Alexander-Shukaev]

Some fancy additional flags you want to tell us about? Post the corresponding rg ... invocation as well please.

[Ruin0x11]

counsel-rg-base-command is "rg --with-filename --no-heading --line-number --color never %s .", if that's what you mean.

When I run rg standalone from cmd, this is the output:

C:\Users\kuzuki\build\test>rg HOP3_at
./zxc: アクセスが拒否されました。 (os error 5)
source.hsp
8204:   goto *HOP3_at
8234:*HOP3_at

I don't have RIPGREP_CONFIG_PATH set in my environment.