abo-abo / swiper

Ivy - a generic completion frontend for Emacs, Swiper - isearch with an overview, and more. Oh, man!
https://oremacs.com/swiper/
2.3k stars 338 forks source link

Not all counsel-find-file actions shown in fullscreen mode #2881

Open alexei-28 opened 3 years ago

alexei-28 commented 3 years ago

Linux Mint 20.1 , Emacs 27.2, I installed Ivy, Swiper and Counsel.

So in sources file of /counsel.el I find this:

(ivy-set-actions
 'counsel-find-file
 '(("j" find-file-other-window "other window")
   ("f" find-file-other-frame "other frame")
   ("b" counsel-find-file-cd-bookmark-action "cd bookmark")
   ("x" counsel-find-file-extern "open externally")
   ("r" counsel-find-file-as-root "open as root")
   ("R" find-file-read-only "read only")
   ("l" find-file-literally "open literally")
   ("k" counsel-find-file-delete "delete")
   ("c" counsel-find-file-copy "copy file")
   ("m" counsel-find-file-move "move or rename")
   ("d" counsel-find-file-mkdir-action "mkdir")))

OK. Nice. Now I want to use e.g. "j" when open file.

So in temp folder (in dired mode) I use command:

M-x counsel-find-file

s1

Then select file file2.txt

s2

Screen is in fullscreen mode. And then press M-o. As result show commands.

s3

But why not show "j" find-file-other-window "other window"?

P.S. When I press "j" then file open in other frame. But why this command is not visible?

basil-conto commented 3 years ago

For posterity, this was already asked on the Emacs SE: https://emacs.stackexchange.com/q/65106/15748

alexei-28 commented 3 years ago

For posterity, this was already asked on the Emacs SE: https://emacs.stackexchange.com/q/65106/15748

I'm not found answer in this link.

basil-conto commented 3 years ago

I'm not found answer in this link.

Sure, but since the question is duplicated in two places, I'm linking one place to the other for posterity.

basil-conto commented 3 years ago

When I press "j" then file open in other frame.

FWIW, I can't reproduce this. Here's what I tried:

  1. make plain

  2. F11

  3. (let* (dir
          (clean (lambda ()
                   (ignore-errors
                     (and dir (delete-directory dir t))))))
     ;; Clean up temporary directory on exit.
     (add-hook 'kill-emacs-hook clean)
     ;; Create temporary parent directory.
     (setq dir (make-temp-file "ivy-" t))
     ;; Create myFolder and fileN.txt in temporary parent directory.
     (make-directory (expand-file-name "myFolder" dir))
     (dotimes (i 2)
       (make-empty-file (expand-file-name (format "file%d.txt" (1+ i)) dir)))
     ;; Visit temporary parent directory in Dired.
     (dired dir))
  4. C-x C-e

    4-fs8

  5. C-x C-f

    5-fs8

  6. M->

    6-fs8

  7. M-o

    7-fs8

All 12 actions, including j, appear in the minibuffer.

The Emacs configurations/versions I tried this in are listed below. BTW, I use the Xmonad tiling window manager, which may affect how Emacs determines the fullscreen mode.

But why this command is not visible?

Probably a miscalculation somewhere in Emacs or Ivy depending on your WM/setup.


Emacs 28 PGTK ``` In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2021-05-24 built on tia Repository revision: 67a4c8b5ad9ebfb3fa2c7fae433aa6b6b5e92154 Repository branch: feature/pgtk Windowing system distributor 'System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache --prefix=/home/blc/.local --program-suffix=-pgtk --enable-checking=structs --with-file-notification=yes --with-pgtk --with-xwidgets' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XIM XWIDGETS GTK3 ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix ```
Emacs 28 GTK3 ``` In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2021-05-24 built on tia Repository revision: 19c14be04fec3ae958bd14623ca2f8f84a53915f Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache --prefix=/home/blc/.local --program-suffix=-gtk --enable-checking=structs --with-file-notification=yes --with-x-toolkit=gtk --with-x' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB ```
Emacs 28 GTK2 ``` In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 2.24.33, cairo version 1.16.0) of 2021-05-24 built on tia Repository revision: 19c14be04fec3ae958bd14623ca2f8f84a53915f Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache --prefix=/home/blc/.local --program-suffix=-gtk2 --enable-checking=structs --with-file-notification=yes --with-x-toolkit=gtk2 --with-x' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK2 ZLIB ```
Emacs 28 Lucid ``` In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2021-06-02 built on tia Repository revision: f064b23d09a354d7b99bc6eebb4be64979a3ba9f Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-Og -ggdb' --config-cache --prefix=/home/blc/.local --enable-checking=structs --with-x-toolkit=lucid --with-file-notification=yes --with-x' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XAW3D XDBE XIM XPM LUCID ZLIB ```
Emacs 27 Lucid ``` In GNU Emacs 27.2.50 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2021-06-01 built on tia Repository revision: bef00aa1372dbd8a72ac84be0ee397cca46a1250 Repository branch: emacs-27 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-O0 -g3 -ggdb -gdwarf-4' --config-cache --prefix=/home/blc/.local --program-suffix=-27 --enable-checking=yes,glyphs --enable-check-lisp-object-type --with-x-toolkit=lucid --with-file-notification=yes --with-x --with-cairo' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP ```
alexei-28 commented 3 years ago

I'm not found answer in this link.

Sure, but since the question is duplicated in two places, I'm linking one place to the other for posterity.

My environment:

Linux Mint 20.1,

GNU Emacs 27.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2021-03-26

I try with another folder and another file. The Emacs is in fullscreen mode.

But the result is same. Not show all commands. s1 s2 s3

P.S. I also try by F11. But it not help. Same result :-(

zzjjzzgggg commented 2 years ago

Having the same issue with Emacs 27.2 on Arch Linux. If I have defined more than 10 actions, ivy M-o shows only bottom 10 of them.