search

abo-abo / swiper

Ivy - a generic completion frontend for Emacs, Swiper - isearch with an overview, and more. Oh, man!
https://oremacs.com/swiper/
2.31k stars 338 forks source link

`counsel-tmm` needs updating for emacs 28 #2996

Closed zabe40 closed 1 year ago

zabe40 commented 2 years ago

The function tmm-get-keybind was removed in emacs 28 (specifically this commit), and counsel-tmm uses this function. Luckily, it looks like (menu-bar-keymap) is a drop-in replacement for (tmm-get-keybind [menu-bar]).

https://github.com/abo-abo/swiper/blob/29b61fe1f4d5268d750b666a7ffc1269e22c6477/counsel.el#L4389

Since I don't actually use counsel, this is an issue and not a pull request. I'm not sure how you handle compatability between different versions of emacs, but I wanted to let you know since I adapted counsel-tmm for my favored completion package (Selectrum), and it broke when I updated to 28.

basil-conto commented 1 year ago

Thanks for pinpointing the issue and its solution! And sorry for the long delay in fixing this.