search

abo-abo / swiper

Ivy - a generic completion frontend for Emacs, Swiper - isearch with an overview, and more. Oh, man!
https://oremacs.com/swiper/
2.27k stars 337 forks source link

Release for Emacs 28 compatibility? #3001

Open sten0 opened 1 year ago

sten0 commented 1 year ago

Hi,

Emacs 28 broke Ivy/Swiper in Debian, and I have less than a week to decide whether to 1) Cherry pick a couple of fixes onto 0.13.4, or 2) Package a git snapshot. Do you have a preference? As far as I can tell there's at least one issue (#2996), which prevents a compatible-with-Emacs28 v0.13.5 release.

The reason I ask about what you'd prefer is because if a stable release isn't made before mid January then whatever I upload now might end up being what ships in Debian 12 (Bookworm).

Kind regards, Nicholas

basil-conto commented 1 year ago

Hi Nicholas,

Sorry for the delayed response - I've been AFK all year due to military conscription in my country, and I think @abo-abo has been AFK even longer. I anticipate being back at a keyboard in mid-December, but unfortunately won't be able to get a point release of Ivy together any earlier than that.

FWIW, I have no particular preference between cherry-picking and Git snapshots. Given the incompatibility you mention in #2996, and that an Ivy release that fixes it is unlikely to land within the next month, a Git snapshot strikes me as making more sense. But I am not familiar with the repercussions of the decision for Debian, so please proceed however you see fit.

Sorry for the trouble, and thank you very much for working on this!

sten0 commented 1 year ago

Hi Basil,

Sorry for the delayed response - I've been AFK all year due to military conscription in my country, and I think @abo-abo has been AFK even longer. I anticipate being back at a keyboard in mid-December, but unfortunately won't be able to get a point release of Ivy together any earlier than that.

Wow, given the context, I'm grateful that you were able to find the time to reply to this issue.

FWIW, I have no particular preference between cherry-picking and Git snapshots. Given the incompatibility you mention in #2996, and that an Ivy release that fixes it is unlikely to land within the next month, a Git snapshot strikes me as making more sense. But I am not familiar with the repercussions of the decision for Debian, so please proceed however you see fit.

Sorry for the trouble, and thank you very much for working on this!

I think you're right, and this also seems like an opportunity to test if b8be491 is suitably release-candidate! Assuming no further commits, and a last-minute Ivy/Swiper release in mid-January, that commit would have been tested for two months by users of Debian unstable and testing (and rolling release derivatives), and would have been in use by all other users for three months. At this point that's what I can provide to answer the question "Is it stable enough for release?"

To be extra safe, maybe a prerelease/beta/release-candidate could be released to MELPA Stable at some point mid-December?

In terms of repercussions, the decision determines the version of Ivy Debian Stable users will depend on from what will probably be Summer 2023 to as late as Summer 2026 (if users choose not to upgrade sooner). That will be either 0.13.4+cherry picks, or 0.13.4+78.gb8be491. In general, everyone wants the newest possible, most featureful, yet stable release.

Thank you, Nicholas

basil-conto commented 1 year ago

...many months later...

Sorry for taking so long to get back to this and for significantly overshooting my time estimate. A couple of weeks ago I addressed the incompatibility reported in #2996, and have now bumped the version to 0.14.0. Is there anything else that needs addressing here? Thanks.