search

abo-abo / swiper

Ivy - a generic completion frontend for Emacs, Swiper - isearch with an overview, and more. Oh, man!
https://oremacs.com/swiper/
2.27k stars 337 forks source link

Support `isearch-fold-quotes-mode` in swiper #3026

Closed skangas closed 8 months ago

skangas commented 8 months ago

Emacs 29 has a new minor mode isearch-fold-quotes-mode. It's very useful when searching in Info and Help mode buffers, and means that you can simply type, for example ' (grave) to search for the regexp ['’] (curved).

Any chance support for it could be added to Swiper?

basil-conto commented 8 months ago

Any chance support for it could be added to Swiper?

Luckily, since isearch-fold-quotes-mode is implemented in terms of search-default-mode, it should™ already work in swiper.

So I'm guessing you're using swiper-isearch instead, where (of course, sigh) there is a bug! :) search-default-mode is consulted in the current buffer, which in the case of swiper-isearch happens to always be the minibuffer (in the case of swiper it alternates between the minibuffer and the original buffer, I'm guessing due to some delightful interplay between post-command-hook and Ivy's handling of per-command update-fns).

basil-conto commented 8 months ago

Hopefully c66769d25b90693ce6eedc3d4dbbf8dbce7b8dcf should be TRT for both swiper and swiper-isearch; let me know if you encounter any issues. Thanks!

skangas commented 8 months ago

Good stuff, thanks for the prompt fix! I'll give it a spin and report back if I find any issues.

BTW, any chance for a new Swiper release on GNU ELPA any time soon?

basil-conto commented 8 months ago

BTW, any chance for a new Swiper release on GNU ELPA any time soon?

I created a new tag in swiper.git, but messed up the push to elpa.git (I absent-mindedly merged rather than cherry-picking the release commit, so GNU ELPA won't pick up the new tag yet). I need to run now but will try to fix elpa.git later today.

basil-conto commented 8 months ago

BTW, any chance for a new Swiper release on GNU ELPA any time soon?

I created a new tag in swiper.git, but messed up the push to elpa.git (I absent-mindedly merged rather than cherry-picking the release commit, so GNU ELPA won't pick up the new tag yet). I need to run now but will try to fix elpa.git later today.

Version 0.14.2 should hopefully be coming to a GNU ELPA near you soon.