aboSamoor / pycld2

Apache License 2.0
165 stars 63 forks source link

Fails to compile with clang, but succeeds with gcc #59

Open gregtatum opened 7 months ago

gregtatum commented 7 months ago

When using clang to compile, I'm getting -Wc++11-narrowing errors which are blocking compilation. I was able to remove clang from my path, and force the build to using gcc, which then succeeded. This is a workaround if anyone else needs it.

      /private/var/folders/y7/0gx4dtxs223gpzqt_6rqjrmm0000gp/T/pip-install-8cxaw5wp/pycld2_8ff418c9577344cebc10f9fd1a688b05/cld2/internal/cld_generated_cjk_uni_prop_80.cc:168:1: error: constant expression evaluates to -14 which cannot be narrowed to type 'uint8' (aka 'unsigned char') [-Wc++11-narrowing]
        168 | -14,-14,-14,-14,-14,-14,-14,-14, -14,-14,-14,-14,-14,-14,-14,-14,
            | ^~~

I think the fix would be to pass in -Wc++11-narrowing as an option to the clang build command to disable this narrowing check. Although I'm unsure if there are other breaking warnings beyond that.

I am using an arm macOS for the record.