search

aboeglin / react-router-v4-transition

React Router V4 Transition
MIT License
39 stars 6 forks source link

Fix a bug in AnimatedSwitch #2

Closed aboeglin closed 7 years ago

aboeglin commented 7 years ago

Remove the unused property onStateChange on the TransitionRoute, child of AnimatedSwitch. Also remove the need to clone the child being returned by render.

Fix the test for AnimatedSwitch which now passes correctly with the full cycle, including WILL_RENDER/DID_ENTER.

Remove the use of this.status in AnimatedSwitch, it now uses only the state.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+9.3%) to 82.143% when pulling 825031a98a10cb57950978208b99aa58c10c7d0a on tests into ce3c20e1c1e3e79d5a6d5a72e42889a328e28d91 on master.