search

abogushov / django-admin-json-editor

Adds json-editor for JSONField in Django Administration
MIT License
173 stars 61 forks source link

fontawesome4 not loaded #2

Closed AdrienLemaire closed 6 years ago

AdrienLemaire commented 6 years ago

Since you auto set the iconlib to fontawesome4, can you also add the django-fontawesome (or django-font-awesome?) dependency to the plugin ? Icons aren't showing to the user if he doesn't have the font installed on his system.

abogushov commented 6 years ago

Hello, I have added fontawesome4 as static for the application so it must work.

AdrienLemaire commented 6 years ago

Sorry, got too busy and forgot to update this. Yes, I had forgotten to collectstatic. Tnx a bunch!

On Wed, Nov 8, 2017, 7:39 PM Alexander Bogushov notifications@github.com wrote:

Hello, I have added fontawesome4 https://github.com/abogushov/django-admin-json-editor/tree/master/django_admin_json_editor/static/django_admin_json_editor/fontawesome as static for the application so it must work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abogushov/django-admin-json-editor/issues/2#issuecomment-342778648, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP7d95OohixKM7GPaHeBOLMCNAxInhOks5s0YT0gaJpZM4QVyPZ .

abogushov commented 6 years ago

Nice!