search

abonander / multipart

A backend-agnostic extension for file uploads in HTTP libraries for Rust
MIT License
190 stars 93 forks source link

upgrade mime & mime_guess to latest version #123

Closed bachue closed 4 years ago

abonander commented 5 years ago

The future of this crate is kinda up in the air right now since I'm working on updating multipart-async to the new version of Hyper. I'm mostly thinking to keep this crate around for whatever synchronous APIs might remain and focusing most of my development effort on multipart-async.

I don't really want to combine them because async multipart reading requires an entirely different architecture due to async Hyper using a Stream<Item = [u8]>-like interface instead of AsyncRead, the latter of which could be easily dropped into this crate. That would basically require adding yet another layer to the crate's module hierarchy and also somehow linking two different versions of Hyper to maintain support for the old synchronous version.

metajack commented 4 years ago

I realize that the future of this crate is uncertain, but can you please land this patch or another fix that updates this?

This is one of a few crates that still depends on mime_guess 1.8 which is actually broken with the experimental feature resolver -Z features.

Draphar commented 4 years ago

I second this. Please merge this @abonander.

abonander commented 4 years ago

0.17.0 published, sorry for the delay everybody.