abonander / multipart

A backend-agnostic extension for file uploads in HTTP libraries for Rust
MIT License
190 stars 93 forks source link

the following packages contain code that will be rejected by a future version of Rust: multipart v0.18.0 #146

Open omac777 opened 1 year ago

omac777 commented 1 year ago

While using the latest nightly, this warning for a future hard error appeared:

The package `multipart v0.18.0` currently triggers the following future incompatibility lints:
> warning: trailing semicolon in macro used in expression position
>    --> /var/home/davidm/.cargo/registry/src/github.com-1ecc6299db9ec823/multipart-0.18.0/src/server/field.rs:30:11
>     |
> 30  |           ));
>     |             ^
> ...
> 174 |               None => invalid_cont_disp!(
>     |  _____________________-
> 175 | |                 "expected additional data after Content-Disposition type",
> 176 | |                 header.val
> 177 | |             ),
>     | |_____________- in this macro invocation
>     |
>     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
>     = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
>     = note: `-A semicolon-in-expressions-from-macros` implied by `-A warnings`
>     = note: this warning originates in the macro `invalid_cont_disp` (in Nightly builds, run with -Z macro-backtrace for more info)
> 
> warning: trailing semicolon in macro used in expression position
>    --> /var/home/davidm/.cargo/registry/src/github.com-1ecc6299db9ec823/multipart-0.18.0/src/server/field.rs:30:11
>     |
> 30  |           ));
>     |             ^
> ...
> 182 |               None => invalid_cont_disp!(
>     |  _____________________-
> 183 | |                 "expected field name and maybe filename, got",
> 184 | |                 after_disp_type
> 185 | |             ),
>     | |_____________- in this macro invocation
>     |
>     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
>     = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
>     = note: `-A semicolon-in-expressions-from-macros` implied by `-A warnings`
>     = note: this warning originates in the macro `invalid_cont_disp` (in Nightly builds, run with -Z macro-backtrace for more info)
> 

Thank you.

michalfita commented 1 year ago

@abonander abandoned this project over 1½ years ago, there's more legacy here that need fixing, but I wouldn't count on it.