abooij / haskell-xkbcommon

Haskell bindings for libxkbcommon
MIT License
7 stars 6 forks source link

expose Text.XkbCommon.InternalTypes #7

Closed dmanam closed 8 years ago

dmanam commented 8 years ago

internal types need to be exposed in order to make interfaces to other C libraries that use xkb_state *s and xkb_keymap *s (e.g. https://github.com/dlahoti/haskell-wlc)

abooij commented 8 years ago

I'm not against this, but let's clearly document the purpose of the InternalTypes module in that case: its contents are re-exported by the Types module in order to avoid exposing hsc2hs-specific identifiers. So unless users want to deal with these identifiers, in order to connect to other C libraries (as you say), they should probably not deal with this.

dmanam commented 8 years ago

Agreed ­– added that disclaimer at the top of the module.

abooij commented 8 years ago

Thanks a lot!