feat(cookie): cookie flags support and minor fixes

aborn / nuxt-openid-connect

OpenID-Connect(OIDC) integration module for nuxt 3.0.

31 stars 16 forks source link

feat(cookie): cookie flags support and minor fixes #7

Closed KhaledAlMana closed 1 year ago

KhaledAlMana commented 1 year ago

Breaking changes

None

Changes

Support runtime configurations in playground (via .env)
fix response_types typo, changed to -> response_type
fix scopes was pilings up caused by:
- defaults were always appended to configured scopes
- openid was added 3 times (from defaults, configurations, and issueClient parameters)

UPDATE 1:

Added support for cookie flags and its documentation to be able to secure cookies if needed, with httpOnly, and secure flags or any other flags.

aborn commented 1 year ago

Get this error when pack.

KhaledAlMana commented 1 year ago

I will check now

aborn commented 1 year ago

temporary solution define CookieSerializeOptions again: https://github.com/aborn/nuxt-openid-connect/blob/main/src/module.ts

If you can find better solution, change it! Thanks.

KhaledAlMana commented 1 year ago

Yes, Thanks, I've checked it already. Totally fine for the moment while I figure out the better solution.

KhaledAlMana commented 1 year ago

Currenlty your temp solution is the cleanest. There are many ways, but not very clean. It will require a bit more time than expected. I will try to take a deeper look into it another time. Thanks for the fix, and the build.