search

abougouffa / minemacs

MinEmacs: an Emacs configuration framework for daily use
https://abougouffa.github.io/minemacs/
MIT License
140 stars 17 forks source link

[suggest] about font set #120

Closed donneyluck closed 10 months ago

donneyluck commented 10 months ago

hi @abougouffa The font setting of emacs has always been a headache, especially for languages ​​​​such as Chinese, English, Japanese and Korean. Here is a solution I saw So I want to ask you to see if you can add to minemacs By the way, it can solve my problem that Chinese and English fonts are not equal in width and height. Thks

here is the code https://github.com/seagle0128/.emacs.d/blob/24aefae42f6bdefcb2638e7836d75feca4803fe4/custom-example.el#L34-L85

abougouffa commented 10 months ago

Thank you for the suggestion. I will take a look to see how can I integrate this effectively!

abougouffa commented 10 months ago

Hi @donneyluck

I've changed how MinEmacs handles fonts. Take a look at skel/config.el if you want to customize the fonts. Now by default, there is a set of fonts (default, Arabic, Han, ...), I've taken the font list from the example you provided.

Thanks again for this suggestion, and let me know if it doesn't work for you!

EDIT:

[!IMPORTANT] Note that, after updating MinEmacs, you need to close it and delete the ~/.minemacs.d/custom-vars.el.

donneyluck commented 10 months ago

it works very well thank you very much But how to set the style of the font, such as bold italic maybe need :weight 'bold

abougouffa commented 10 months ago

For the moment the only supported settings are :family and :height. I will try to refactor the code to accept additional parameters in the future.

abougouffa commented 10 months ago

Hello @donneyluck

Now you should be able to pass extra arguments like :weight and so on.

donneyluck commented 10 months ago

Hi @abougouffa
Thanks again