search

abougouffa / minemacs

MinEmacs: an Emacs configuration framework for daily use
https://abougouffa.github.io/minemacs/
MIT License
140 stars 17 forks source link

[BUG] theme revert back during commit change with magit #136

Closed emacsbliss closed 8 months ago

emacsbliss commented 8 months ago

Describe the bug If I use consult-theme to load a different theme than the value of minemacs-theme, after invoke magit and perform a commit for staged changes, Emacs will revert back to the theme specified by minemacs-theme during entering the commit message and stay with it afterwards.

Emacs version

GNU Emacs 29.1 (build 2, aarch64-apple-darwin22.2.0, NS appkit-2299.30 Version 13.1 (Build 22C65)) of 2023-10-14

Checkup list

To Reproduce Steps to reproduce the behavior:

  1. start Emacs
  2. use consult-theme to switch theme to something other than the one from minemacs-theme
  3. run M-x magit on any of the git repo
  4. stage some change for the repo
  5. run C-c C-c to bring up the commit message buffer
  6. theme will revert back to the one from minemacs-theme

Expected behavior theme should remain the one I manually changed using consult-theme and not revert to the one from minemacs-theme

abougouffa commented 8 months ago

Thank you for the feedback @emacsbliss, it should be fixed now!