search

abougouffa / minemacs

MinEmacs: an Emacs configuration framework for daily use
https://abougouffa.github.io/minemacs/
MIT License
143 stars 16 forks source link

evil-escape can not escape from iedit & evil-mc #30

Closed donneyluck closed 1 year ago

donneyluck commented 1 year ago

hi @abougouffa after my test evil-escape kj or fd can not escape from evil-iedit-state & evil-mc so maybe need support it thks

abougouffa commented 1 year ago

Hello @donneyluck ,

The evil-iedit-state is supported by evil-escape, the current MinEmacs config leaves the C-; bound to iedit-mode. I will change it to evil-iedit-state/iedit-mode instead, this should solve the issue for iedit. EDIT: this commit d95e91d139fe133c128bb1b7d58cc372d3b53ca4 implement this.

However, for evil-mc, I don't know how to integrate it efficiently with evil-escape. Feel free to share a solution if you found one!

PS: I'm changing the evil-escape-key-sequence to "kj" like you've suggested before https://github.com/abougouffa/minemacs/pull/21/commits/0cf430e8d2d1b145884371d08d47fc939f8f640b. It makes more sens than "fd" which interferes with evil-find or evil-snipe-f.

PS2: I've experienced several issues with evil-mc in the past, I'm planning to replace it with evil-multiedit. I will leave the current configuration in modules/obsolete/me-evil-mc.el once replaced with evil-multiedit.

donneyluck commented 1 year ago

thank you for your time