search

abougouffa / minemacs

MinEmacs: an Emacs configuration framework for daily use
https://abougouffa.github.io/minemacs/
MIT License
143 stars 16 forks source link

skel/module.el minemacs-core-modules not equal #35

Closed donneyluck closed 1 year ago

donneyluck commented 1 year ago

minemacs-core-modules (skel/module.el) not equal to (core/me-module.el) i think maybe core module should not be modified Should it be removed from module.el if you want keep it. it should be equal default me-defaults & me-bootstrap should be delete

skel/module.el

(setq minemacs-core-modules
      '(me-defaults      ;; Tweak Emacs defaults
        me-splash        ;; Simple splash screen (inspired by emacs-splash)
        me-bootstrap     ;; Bootstrap straight.el
        me-core-ui       ;; Theme and modeline
        me-keybindings   ;; general.el, which-key, hydra, ...
        me-evil          ;; evil, evil-collection, evil-mc, ...
        me-completion))  ;; vertico, marginalia, corfu, cape, consult, ...

core/me-module.el

(defcustom minemacs-core-modules
  '(me-splash        ; Simple splash screen
    me-keybindings   ; Keybinding (general, which-key, hydra, ...)
    me-evil          ; Emacs as Vim (evil, evil-collection, evil-mc, ...)
    me-core-ui       ; Core UI (doom-themes, modus-themes, doom-modeline, ...)
    me-completion)   ; Completion (vertico, marginalia, corfu, cape, consult, ...)
  "MinEmacs enabled core modules."
abougouffa commented 1 year ago

Yep, you're right. At some time, I've changed the way the modules are loaded. The me-defaults and me-bootstrap cannot be disabled. I should update the skeleton modules file.

Thank you for reporting this

donneyluck commented 1 year ago

ok thks ~