search

abougouffa / minemacs

MinEmacs: an Emacs configuration framework for daily use
https://abougouffa.github.io/minemacs/
MIT License
143 stars 16 forks source link

Cannot disable posframe? #54

Closed jonathanwilner closed 1 year ago

jonathanwilner commented 1 year ago

Hi,

Probably a silly question related to my own config, but I've hunted and hunted to find what changed re: completion using what looks like posframe. Is it actively enabled somewhere? I can't find anything that would indicate it's in use, including variables, but the completion sure looks like it's using it. Any tips appreciated or a quick - "that's on you!" would be great too.

Thanks again for such an awesome configuration !

abougouffa commented 1 year ago

Hello @jonathanwilner ,

I'm not sure if I've understood your question. If you can provide a screenshot or a GIF, it would be helpful.

If you are looking for the package responsible for MinEmacs' completion in a child frame (the built-in feature used by posframe), it is corfu. There are 2 modes directly involved, corfu-mode and corfu-popinfo-mode:

image

These are configured in me-completion. By default, corfu-mode is enabled globally. If you want to enable it only in some modes, let's say, prog-mode, you can add something like this to your config:

(remove-hook 'minemacs-after-startup-hook #'global-corfu-mode)
(add-hook 'prog-mode-hook #'corfu-mode)
abougouffa commented 1 year ago

You can also leave corfu enabled globally and tweak the corfu-exclude-modes customization variable (for example, to exclude org-mode).

(with-eval-after-load 'corfu
  (push 'org-mode corfu-exclude-modes))
lllouisus commented 1 year ago

i love this framework, thanks for your work! @abougouffa

abougouffa commented 1 year ago

Thanks @xanmodlouis , Happy you've found it useful!

abougouffa commented 1 year ago

@jonathanwilner did my comment answers your question?

jonathanwilner commented 1 year ago

Yes, it put me on the right track re corfu and corfu-terminal . Thank you !

On Fri, May 5, 2023 at 19:43 Abdelhak Bougouffa @.***> wrote:

@jonathanwilner https://github.com/jonathanwilner did my comment answers your question?

— Reply to this email directly, view it on GitHub https://github.com/abougouffa/minemacs/issues/54#issuecomment-1536971229, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEOIBZSYFM32IVD2XGLJ4TXEWUDDANCNFSM6AAAAAAXNIN5DA . You are receiving this because you were mentioned.Message ID: @.***>