abougouffa / minemacs

MinEmacs: an Emacs configuration framework for daily use
https://abougouffa.github.io/minemacs/
MIT License
143 stars 16 forks source link

about org-mode org-src #55

Closed donneyluck closed 1 year ago

donneyluck commented 1 year ago

@abougouffa hi In the past few days, when I use org-mode to insert code blocks, there will be smart prompts

But after the latest update, after I press <, it won't help me to complete the code type, I don't know what happened

not the package yasnippet

just press < then can choose src code type

donneyluck commented 1 year ago

image

donneyluck commented 1 year ago

https://github.com/abougouffa/minemacs/commit/9360b69ca944b5b044d7032ca2953388bb7fc55c

this commit (corfu-exclude-modes '(org-mode markdown-mode)) will cause this problem

abougouffa commented 1 year ago

Hello @donneyluck ,

Thank you for bringing this to my attention.

It is the change you mentioned which triggers this behavior. I disabled corfu in org-mode because I was getting annoying word completion based on dabbrev (or something like it).

It is indeed useful to enable corfu for better completion of snippets.

I will patch this soon, thanks again!

abougouffa commented 1 year ago

Fixed in be458ac11783280643bcf75c0332231bb7fb63dc.