search

abougouffa / pyIslam

pyIslam, a Python library to calculate prayer times, hijri date, qiblah direction and more
http://abougouffa.github.io/pyIslam
GNU Lesser General Public License v3.0
93 stars 31 forks source link

Fix the Hijri calculation method or find an other one #6

Open abougouffa opened 10 years ago

abougouffa commented 10 years ago

The current method taken from http://www.icoproject.org/pdf/2001_conv.pdf This method give always a fixed 30 days value for the Ramadan month!! :-1:

monsef-alahem commented 4 years ago

assalamo alykom, im monsef nice to meet you Abdelhak Mohammed, intersting project ! for hijri - gegorian convertion, take a look at https://github.com/monsef-alahem/date_converter

abougouffa commented 4 years ago

Thank you @monsef-alahem, and congratulations for your implementation :smiley:

I started this project when I was in high school, I haven't worked on it from a while.

I had a quick look on the notes on Dr Aly Abbara website, he uses a method recommended by Jean Meeus in his book La saga des calendriers ou le frisson millénariste, this method is almost the same as the one used in my implementation, and it suffers from the same problem of a fixed 30 days for Ramadan, which is obvious because it is based on simple Julian day to Hijri calendar conversion.

I guess for solving Ramadan 29 or 30 issue, we need to fuse this method with another method based on observability of the new moon, something like the one used by Dr. Monzur Ahmed in Moon Calculator or the one used by Mahamed Odeh in Accurate Times

In fact, I'm too busy this days, but I will try to take a deeper look as soon as I got some free time.

monsef-alahem commented 4 years ago

oh ! im sorry, i got 29 in ramadan for some dates, so i though it was different method. Well, i don't have the level right now to correct the convertion date, but i think i can do something about zakat and mirat features, i hope it is not too late for me to contribute :)

abougouffa commented 4 years ago

Of course @monsef-alahem your are welcome anytime, it will be a pleasure to have you as a contributor.

Don't be sorry, maybe I'm wrong, because I haven't checked the original calculation method, maybe this one gives a variable length; I have to check it.

Me too, I'm not an astronomy specialist, I started this project as a personal project, it was a hobby :smile:

monsef-alahem commented 4 years ago

thank you very much :D, i will try my best inchaa Allah, i'll send the code in apropriate issue as soon as posible.

abougouffa commented 3 years ago

To be done:

Port and test the Umm al-Qura Calendar from: