aboul3la / Sublist3r

Fast subdomains enumeration tool for penetration testers
GNU General Public License v2.0
9.73k stars 2.1k forks source link

Use feature detection, avoid bare exceptions, avoid comparing types #231

Closed cclauss closed 3 years ago

cclauss commented 4 years ago

Python porting best practice use feature detection instead of version detection.

Bare exceptions: https://realpython.com/the-most-diabolical-python-antipattern

PEP8: Object type comparisons should always use isinstance() instead of comparing types directly.

unicode was removed in Python 3 because all str are Unicode utf-8.