search

abouolia / sticky-sidebar

😎 Pure JavaScript tool for making smart and high performance sticky sidebar.
https://abouolia.github.io/sticky-sidebar/
MIT License
2.23k stars 489 forks source link

Never hitting affix.bottom.stickySidebar when sidebar bottom height is less than topSpacing #67

Open presto2116 opened 6 years ago

presto2116 commented 6 years ago

I have a sticky top nav so I am using topSpacing: 80 to account for the nav height. it seems like if the bottom of the sticky sidebar is less than 80px outside of viewport, the sticky sidebar affix.top.stickySidebar instead of scrolling to the bottom of the sidebar and affix.bottom.stickySidebar. I have tried changing bottomSpacing to a larger number, but that does not seem to work. I have also added padding-bottom on the .sidebar__inner. which works but adds a lot of space below the sticky footer when its affixed to the bottom.

Not sure if I am missing something or adding padding-bottom to .sidebar__inner is the only solution for this.

Other than that, sticky-sidebar is working amazingly! Using it all over my site

presto2116 commented 6 years ago

Just realized this is a duplicate issue of 'Sidebar fits viewport method need to take top/Bottom spacing into the equation'. Issue #53. And it says it has been updated. When will that update be released?