Fix gunicorn >= 19.0 support in gunicorn worker

abourget / gevent-socketio

Official repository for gevent-socketio

http://readthedocs.org/docs/gevent-socketio/en/latest/

BSD 3-Clause "New" or "Revised" License

1.21k stars 331 forks source link

Fix gunicorn >= 19.0 support in gunicorn worker #242

Open niligulmohar opened 8 years ago

niligulmohar commented 8 years ago

With this change the socket.socket API is used directly for sockets that don't have any version of the gunicorn.sock.BaseSocket address attribute, which is necessary since gunicorn 19.0 and this commit:

https://github.com/benoitc/gunicorn/commit/9a83d719b23fe28667a9c76bac25ba66651f8ccf

niligulmohar commented 8 years ago

... and now i found #211 :sweat:

Well, i prefer this solution, since it will support any socket.socket like object through duck typing instead of just the gevent.socket.socket variety. Do you have an opinion @jares777?

jares777 commented 8 years ago

Yes I agree with you. I am glad to see that there is life again in this package. I have been using it in production for last one year without any issues.