aboutcode-org / pip-requirements-parser

a mostly correct pip requirements parsing library
MIT License
20 stars 10 forks source link

Specify packaging version #11

Closed wellshs closed 1 year ago

wellshs commented 1 year ago

https://github.com/nexB/pip-requirements-parser/issues/10

wellshs commented 1 year ago

@pombredanne Hi! can you review this one?

pombredanne commented 1 year ago

@wellshs Thanks.... I think we need a bit more than this. In particular we would need to either:

Your proposed requirements.update only work if using a checkout and running configure, and will not fix a pip install pip-audit

pombredanne commented 1 year ago

I am closing in this in favor of https://github.com/nexB/pip-requirements-parser/pull/3 Thank you ++ for reporting the issue and helping fixing this.

wellshs commented 1 year ago

Oh, thanks for kind explanation and fixing this issue! I will check out patch work to me!