search

aboutcode-org / pip-requirements-parser

a mostly correct pip requirements parsing library
MIT License
20 stars 10 forks source link

Fix NameError resulting from Path without import specification #17

Open vreuter opened 1 year ago

vreuter commented 1 year ago

Close #16

Hit the issue described in #16 and went with the suggestion posted there, just opting for import of the library and the qualified name at the call site, to match what looks like the import standard for this project (or at least for the relevant file).

vreuter commented 1 year ago

Thank you ++ Do you think you could add a small test to ensure we will not regress?

Yeah absolutely, can you advise on where best to place it? I looked around the tests/ and it looks like there are a couple candidates, happy to go with whatever project creators / maintainers prefer @pombredanne

Do you understand why the CI fails? From quick glance I couldn't tell what's prompting the errors on this first commit, compared with the latest commit on main

Akasurde commented 1 year ago

Any updates?

jkowalleck commented 1 year ago

is superseded by #19