fix RequirementsFile.from_string

aboutcode-org / pip-requirements-parser

a mostly correct pip requirements parsing library

MIT License

20 stars 10 forks source link

fix RequirementsFile.from_string #19

Open jack-joindeed opened 1 year ago

jack-joindeed commented 1 year ago

fixes #16
makes the from_string method actually usable
uses a NamedTemporaryFile instead of custom logic

Note: there are 5 tests that are failing on the main branch and those continue to fail on this branch. No new errors were introduced (to my knowledge)

Akasurde commented 1 year ago

Any Updates?

jkowalleck commented 1 year ago

@pombredanne please merge this one.

it supersedes #17

pombredanne commented 1 year ago

@jkowalleck sure thing... I need to understand why we have massive tests failures and we would likely need to get the latest skeletton

pombredanne commented 1 year ago

Test are fixed and and will be merged alright. This comes next.

jkowalleck commented 1 year ago

@jack-joindeed thanks for updating according to https://github.com/nexB/pip-requirements-parser/pull/19#discussion_r1379279880

could you rebase onto latest upstream/main tests are passing, there, according to https://github.com/nexB/pip-requirements-parser/pull/19#issuecomment-1788103708

jack-joindeed commented 1 year ago

@jkowalleck I'm already rebased up to c009a483a899f0b39b474be434ef5c9cf7fe0a41 which is the HEAD of main in this repo, but tests are still failing for me locally and in this PR.