search

aboutcode-org / pip-requirements-parser

a mostly correct pip requirements parsing library
MIT License
20 stars 10 forks source link

line_number property typed to Optional[str] #8

Open whardier opened 1 year ago

whardier commented 1 year ago

https://github.com/nexB/pip-requirements-parser/blob/0da228a3229dfb0074dad202e3dc7f9cf4103a23/src/pip_requirements_parser.py#L420

Also please add a py.typed to your distribution. I believe it is all 100% typed and mypy thinks otherwise since this is missing.

PR #9

pombredanne commented 1 year ago

Also please add a py.typed to your distribution. I believe it is all 100% typed and mypy thinks otherwise since this is missing.

What's the catch if any? And if there is none, what need to be done to validate this? PR is mucho welcomed.