Closed AyanSinhaMahapatra closed 3 years ago
@JonoYang @tdruez Thank you for reviewing! I've made the changes you requested above. @pombredanne did a lot of reviewing and restructuring over our calls, so the code format and readability are thanks to him.
Changes made in the last force-push,
get_error_rule_sub_type
and update ERROR_RULE_SUB_TYPE_CHOICES
predict_license_key
function [Aggregate all keys, and key with most occurrences could be the prediction, and then compare length of match if same number of occurances]Changes made in the last force-push -
Other minor changes -
@pombredanne Yes, the tests pass. I thought the travis builds were turned off so I added github action workflows. #37
Edit: No, they fail. The test expectations should change a bit because of the scancode version update (URLs change to licensedb and is_license_intro
flag added). I was using the older one locally as it was failing before. I will update them.
@pombredanne Tests pass now. The documentation test fails but that's addressed separately at #33
Adds a scancode post-scan plugin to analyze scancode license scan errors, results of which are added as scancode resource attributes. Adds tests for the plugin and analysis functions.
Fixes #20
Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com