search

aboutcode-org / scancode-plugins

A set of plugins either delivered as builtin scancode-toolkit or extra plugins
2 stars 8 forks source link

Fix renamed CommandLineOption #10

Closed larsla closed 3 years ago

larsla commented 3 years ago

This PR fixes the plugins after CommandLineOption was renamed to PluggableCommandLineOption in the scancode package.

pombredanne commented 3 years ago

@larsla Thank you and sorry for the late review! Do you mind to add a DCO signoff to your commits or at least as a comment in this PR before I can merge?

pombredanne commented 3 years ago

@larsla gentle ping: do you mind to add a DCO signoff, at least as a message in this PR? This looks like here at the bottom: https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html Mine would be: Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com> Thanks!

pombredanne commented 3 years ago

gentle ping

larsla commented 3 years ago

@pombredanne Sorry, these notifications got lost in everything else. How does it look now?