Add new builtin plugin for msitools binaries

aboutcode-org / scancode-plugins

A set of plugins either delivered as builtin scancode-toolkit or extra plugins

2 stars 8 forks source link

Add new builtin plugin for msitools binaries #12

Closed JonoYang closed 3 years ago

JonoYang commented 3 years ago

This is a new builtin plugin that compiles msitools and packs the binaries into a locationprovider plugin. This is used for https://github.com/nexB/scancode-toolkit/issues/2559 and related to https://github.com/nexB/scancode-toolkit/issues/2565

JonoYang commented 3 years ago

@pombredanne I've addressed your comments. Quick question about license: I noticed that builtins/packagedcode_msitools-linux/src/packagedcode_msitools/bin/msidiff and builtins/packagedcode_msitools-linux/src/packagedcode_msitools/bin/msidump have the gpl-2.0-plus license header. The library msitools is licensed under lgpl-2.1-plus. Would the proper license expression for packagedcode_msitools be apache-2.0 AND lgpl-2.1-plus AND gpl-2.0-plus?