search

aboutcode-org / scancode-server

This project is no longer maintained. Visit https://github.com/nexB/scancode.io/ instead for similar and current project
https://github.com/nexB/scancode.io/
19 stars 17 forks source link

Reformatted codebase to follow pep8 guidelines #104

Closed Monal5031 closed 6 years ago

Monal5031 commented 7 years ago

Used coala to fix all formatting issues locally. Integrated coala with travis to raise formatting issues in PR itself from now on.

Fixes #101

Monal5031 commented 7 years ago

@pombredanne @singh1114 @RajuKoushik Please review this PR the travis is now green 😄 , sorry for late fix didn't get a chance to update the branch. I've used coala locally to fix the formatting issues and if this is merged the formatting errors will be shown in PR itself under the python 3.6 tab of travis. Also coala follows pep8 guidelines while formatting.

Monal5031 commented 6 years ago

@pombredanne @jayvdb Please take a look now. I tried max_line_length=100 but it still had many violations, so updated with 120.

pombredanne commented 6 years ago

@Monal5031 this looks decent now alright .... but since this is touching several files, you now have a responsibility I merge this now: You will need to rebase and/or resolve any conflicts in the pending PRs in https://github.com/nexB/scancode-server/pulls ? Do you think you could do this? that should not be a huge amount of work. I can even bring in these PR branches in this repo if this helps.

Monal5031 commented 6 years ago

@pombredanne Okay sure, I checked. this change won't cause much merge conflicts, though we'll be needing rebases over all PRs. Also, some of them might fail Travis as they will also need to run coala. I can fix this repository if it breaks 😄

pombredanne commented 6 years ago

@Monal5031 I take your word for it that you fix the mess that may come! So please start working on it now :P

Monal5031 commented 6 years ago

Okay @pombredanne will head onto them as soon as this is merged 😃

pombredanne commented 6 years ago

You will also need to adjust your commit comment style to be imperative in the future.

Monal5031 commented 6 years ago

Sure 👍 , working on the old PRs