aboutcode-org / scancode-server

This project is no longer maintained. Visit https://github.com/nexB/scancode.io/ instead for similar and current project
https://github.com/nexB/scancode.io/
19 stars 17 forks source link

Add installation script #107

Open chetanya-shrimali opened 6 years ago

chetanya-shrimali commented 6 years ago

run using source ./installation.sh It will do following things:

Signed-off-by: chetanya-shrimali chetanyashrimalie5@gmail.com

chetanya-shrimali commented 6 years ago

regarding #106 Plz review @singh1114 @pombredanne

chetanya-shrimali commented 6 years ago

scancode3 It can also be written as mentioned above. Actually it is able to execute using git bash on windows but what it will do is install the requirements only. We i will have to add if-else condition and define methods for windows. I can proceed to it if you are ok with it. @pombredanne plz review!!

pombredanne commented 6 years ago

The point is not it executes, but that it pass the tests on Python3. If you can install and pass the tests of https://github.com/nexB/scancode-toolkit on Python3 that would be news to me.

chetanya-shrimali commented 6 years ago

@pombredanne That was the problem we discussed earlier regarding issue #100 in pr #105. And finalized that we have to consider that the user has already installed scancode-toolkit . If we keep in mind that, then there is no further need install scancode-toolkit requirement and it will pass. Plz correct me if i got your point the wrong way 😉

pombredanne commented 6 years ago

scancode-toolkit DOES NOT RUN on Python3, therefore scancode-server that depends on scancode-toolkit CANNOT RUN on Python3, simple.

chetanya-shrimali commented 6 years ago

@pombredanne Pardon, but i changed it to Python 2.7 😓

chetanya-shrimali commented 6 years ago

@pombredanne plz review!

chetanya-shrimali commented 6 years ago

@pombredanne The error is at line 11 of etc/conf/dev/base.txt. Error message is no module named encodings. Which comes when running install.sh.

pombredanne commented 6 years ago

Thanks. I think you have copied too much from scancode etc/ ..... take only what is strictly needed. Not everything. Also how come there are 17K+ file changed? that does not sound right?

What is media/AnonymousUser ? Why did you commit bin, lib, include and all your local virtual env things? This should never be commited and part of the gitignore (see the gitignore in scancode-toolkit)

pombredanne commented 6 years ago

Thanks!. what is the etc/configure2.py file in the commits?

pombredanne commented 6 years ago

And what are the changes you made to the original script?

chetanya-shrimali commented 6 years ago

This is not the final commit :sweat_smile:

chetanya-shrimali commented 6 years ago

@pombredanne plz review. I will document it after we reach on a common solution. Thanks!

pombredanne commented 6 years ago

Thanks! Your commit message needs to match our style. It is missing a signed-off-by and the subject should use the imperative style eg

Add installation script #106

Signed-off-by: name <email>
chetanya-shrimali commented 6 years ago

screenshot from 2018-01-27 16-58-32 @pombredanne i have added wincertstore in third-party dir than why does it show error?

chetanya-shrimali commented 6 years ago

@pombredanne Its been a while since the pr was opened. @singh1114 plz review.