search

aboutcode-org / scancode-toolkit

:mag: ScanCode detects licenses, copyrights, dependencies by "scanning code" ... to discover and inventory open source and third-party packages used in your code. Sponsored by NLnet project https://nlnet.nl/project/vulnerabilitydatabase, the Google Summer of Code, Azure credits, nexB and others generous sponsors!
https://aboutcode.org/scancode/
2.15k stars 553 forks source link

License classification for fraunhofer-fdk-aac-codec #1352

Open LeChasseur opened 5 years ago

LeChasseur commented 5 years ago

The classification as "Copyleft Limited" for fraunhofer-fdk-aac-codec seems wrong for two reasons:

  1. It is not an open source license since it explicitly excludes a patent license ("3. NO PATENT LICENSE", "Patent licenses for necessary patent claims for the FDK AAC Codec (including those of Fraunhofer) may be obtained through Via Licensing (www.vialicensing.com) or through the respective patent owners individually for the purpose of encoding or decoding bit streams in products that are compliant with the ISO/IEC MPEG audio standards."

  2. There is no limitation for the requirement to provide the source code of modified versions, in particular the copyleft is not restricted to libraries ("You must make available free of charge copies of the complete source code of the FDK AAC Codec and your modifications thereto to recipients of copies in binary form." - "modification" could be interpreted as in GPL-3.0).

I suggest to classify the license as "Proprietary" (which seems to be called "commercial" - which is misleading since all FOSS can be commercially used)

pombredanne commented 5 years ago

@LeChasseur Hi! thank you++ for chiming in A proprietary-related category most likely makes sense here alright. @DennisClark what's your take? @LeChasseur is quite the expert there. Also it would be worth reviewing existing categories so they are better documented IMHO.

Then I think that Commercial is for something that would require some signed contract and payment of sorts. But I am not entirely clear about the differences between a Free Restricted and a Proprietary Free categories.

Now here are all the categories we have today with some examples:

Free and open source licenses:

These are likely fairly clear:

Non open source licenses:

These categories are not super clear/well defined to me and may need some refinement?

(The bare Proprietary Category is used only by two licenses and is a typo of mine.)

Miscellaneous:

LeChasseur commented 5 years ago

I agree to the following categories:

  1. Free and open source licenses:

    • Copyleft such as gpl-2.0 or `agpl-3.0
    • Copyleft Limited such as lgpl-2.1 or mpl-2.0
    • Permissive such as bsd-new, mit, apache-2.0

  2. Proprietary licenses:

However "commercial" is not a criterion of differentiation since the term is unclear and FOSS can be sold too. I know that some companies offering software under a dual licensing model (i.e. proprietary and FOSS) are using the term to classify a proprietary license but this term misleading (one copies from the other).

  1. Other/Miscellaneous

    • Public Domain such as a simple public-domain dedication makes sense to me. However, it would be helpful to distinguish cases in which the author has dedicated the work to the public domain and other cases in which a program is public domain because it is a govermental work . The reason is that govermental works might be copyright protected in other countries

    • Unstated License such as unknown, unknown-license-reference etc is ok

    I think that the category Patent License is difficult and might be misleading. If there is no free copyright license the license is just proprietary. Marking that a license has explicit patent language would be helpful, though.

The classification by ifrOSS might be of interest: https://github.com/LeChasseur/ifrOSS/blob/master/Lizenzcenter.md

DennisClark commented 5 years ago

I think it makes sense to merge the Free Restricted licenses into just plain Proprietary.

I think it is important to note that what is really meant by Commercial is Contractual (or Contract Required) meaning that the software requires a specific agreement between both parties. Perhaps that Category could be renamed to Contractual and I think it is a distinction worth retaining.

And I still like Proprietary Free (or Free Proprietary) as an indication that yes, you can use the software for free (at least initially, and under certain circumstances) even though one day you might need to get a commercial (contractual) license agreement to do what you really need to do with the software.

pombredanne commented 5 years ago

Actually let me reopen this... this seems this was auto closed. But we have not finished the discussion on categories

pombredanne commented 5 years ago

@LeChasseur @DennisClark are we done on the categories and are we good with the status quo? or not?