aboutcode-org / scancode-toolkit

:mag: ScanCode detects licenses, copyrights, dependencies by "scanning code" ... to discover and inventory open source and third-party packages used in your code. Sponsored by NLnet project https://nlnet.nl/project/vulnerabilitydatabase, the Google Summer of Code, Azure credits, nexB and others generous sponsors!
https://aboutcode.org/scancode/
2.13k stars 550 forks source link

Multiline copyright missing from license file #3796

Open vw-anton opened 5 months ago

vw-anton commented 5 months ago

Description

We found a package where author/copyright information is missing from a license file. It looks like only the first author of a list is represented in the scan result.

How To Reproduce

https://github.com/formidablelabs/victory.git commit dd86278d205f3f306e2ab38c317a6f9c56f0a6f8

Copyrights found:

 copyrights:
      - statement: "Copyright (c) 2014-present, Facebook, Inc."
        location:
          path: "packages/victory-core/src/victory-util/immutable-types.d.ts"
          start_line: 2
          end_line: 2
      - statement: "Copyright (c) 2015-2020 Formidable Labs"
        location:
          path: "LICENSE.txt"
          start_line: 3
          end_line: 3
      - statement: "Copyright (c) 2016-2020 Alexey Svetliakov <https://github.com/asvetliakov>"
        location:
          path: "LICENSE.txt"
          start_line: 5
          end_line: 5

However in the LICENSE.txt file we can see:

Copyright (c) 2016-2020 Alexey Svetliakov <https://github.com/asvetliakov>,
snerks <https://github.com/snerks>, Krzysztof Cebula <https://github.com
Havret>, Vitaliy Polyanskiy <https://github.com/alreadyExisted>, James Lismore
<https://github.com/jlismore>, Stack Builders <https://github.com
stackbuilders>, Esteban Ibarra <https://github.com/ibarrae>, Dominic Lee
<https://github.com/dominictwlee>, Dave Vedder <https://github.com
veddermatic>, Alec Flett <https://github.com/alecf> and potentially other
DefinitelyTyped contributors.

System configuration

For bug reports, it really helps us to know:

pombredanne commented 5 months ago

Good catch! FWIW the file at https://github.com/FormidableLabs/victory/blob/main/LICENSE.txt is problematic in multiple ways:

See https://github.com/FormidableLabs/victory/commit/591fba68afdee05d1a86a5c23baa7613a4deff41

vw-anton commented 5 months ago

So how to proceed on that?

vw-anton commented 4 months ago

@pombredanne Any comment?