search

aboutcode-org / scancode-workbench

:bar_chart: ScanCode Workbench is a desktop app to review and conclude license and origin from code scans generated by ScanCode Toolkit.
https://github.com/nexB/scancode-workbench/releases/latest
Apache License 2.0
156 stars 70 forks source link

Unit tests #591

Closed OmkarPh closed 1 year ago

OmkarPh commented 1 year ago

Also fixes #601

AyanSinhaMahapatra commented 1 year ago

Merging! https://github.com/nexB/scancode-workbench/pull/591#pullrequestreview-1696970683 can be addressed at https://github.com/nexB/scancode-workbench/pull/556

OmkarPh commented 1 year ago

LGTM @OmkarPh, thanks!

Some minor things to note:

  1. Are https://github.com/nexB/scancode-workbench/tree/feature/unittests/test-old and https://github.com/nexB/scancode-workbench/tree/feature/unittests/test-db used currently and if not should they not be removed entirely?

This, was fixed in other branch. If you see the v4.0-react-typescript branch, these don't exist there

  1. The husky pre-commit increases the time to create commits, and usually we run only linters and other smaller/faster checks in pre-commits, and not the full test-suite? This time will increase when there are more comprehensive tests so this is something that should be considered.

But we can do these separately too, feel free to merge.

Ohk, lets discuss about this later