aboutcode-org / scancode-workbench

:bar_chart: ScanCode Workbench is a desktop app to review and conclude license and origin from code scans generated by ScanCode Toolkit.
https://github.com/nexB/scancode-workbench/releases/latest
Apache License 2.0
154 stars 70 forks source link

UI improvements in Dependencies dashboard & Packages explorer #594

Closed OmkarPh closed 1 year ago

OmkarPh commented 1 year ago

Updated charts: image

Dependencies summary table: image

Tabulated dependencies in the package view itself (Dependencies explorer on the left still works as before) image

The packages view on the right didn't require much horizontal space, hence it was set to a default ~50% before But, with the added table, it's changed to a default 65% (Suggest any other ratios, which suit better in most cases) (It is resizable as usual)

mjherzog commented 1 year ago

A minor point but names like Packages Explorer should be singular in most cases - e.g., Package Explorer

OmkarPh commented 1 year ago
  1. In the left main views section and the view in the bar above we have Packages Explorer, but once you're there the header is Packages and Dependencies explorer. We have to be consistent here and use only one. I'm leaning towards Packages Explorer here, but your call.

Yep, having only Package Explorer makes sense.

  1. In the Packages Explorer when you click on one of the dependencies on the left, you have the details with the dependency attributes and their values. Then you have their respective raw JSON there but it's titled Raw package, it should be Raw dependency instead?

My bad, it has to be Raw dependency

OmkarPh commented 1 year ago
  1. In the dependency info dashboard, in the table of values by package type, maybe we should have a title for the table like we have for other charts?

I don't have a good title on top of my head, but what would be a good word to collectively represent Runtime, Optional & Resolved

mjherzog commented 1 year ago

The name that we usually use for Runtime, Optional etc. Dependency Scope.

OmkarPh commented 1 year ago
  1. In the dependency info dashboard, in the table of values by package type, we have a No Value detected there. I'm not sure we have PURLs without package types here, do you have an example of this? In any case let me check SCTK if there are actual instances of these. If not we can remove this row, and irrespective of that, we should only show this if there are values with no package type.

Actually, I didn't get this No value detected anywhere, Can you send me the particular scan, I'll have a look For example, image

OmkarPh commented 1 year ago

The name that we usually use for Runtime, Optional etc. Dependency Scope.

I can think of some options:

AyanSinhaMahapatra commented 1 year ago

Actually, I didn't get this No value detected anywhere, Can you send me the particular scan, I'll have a look For example,

Sure, here's a scan that had this value, attaching a screenshot too. elasticsearch_v32rc4.json.txt no_value_detected

I checked other JSONs and this does not seem to be present in all of them.

Also just a nit, notice how the table has only a few rows but takes up a lot more space than necessary, we should probably reduce the table height when there's not enough rows?

OmkarPh commented 1 year ago

Hi @AyanSinhaMahapatra I've done the changes requested

For the table width & height, there are some other changes in other branches which need to be taken into account, hence it is tracked separately in #598

OmkarPh commented 1 year ago

Thanks @AyanSinhaMahapatra Merging this